Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using KMS #1

Open
mthenw opened this issue Nov 25, 2016 · 6 comments
Open

Consider using KMS #1

mthenw opened this issue Nov 25, 2016 · 6 comments

Comments

@mthenw
Copy link

mthenw commented Nov 25, 2016

https://aws.amazon.com/kms/

With this plugin secrets are actually exposed during the deployment so I would not recommend that as a secure solution. I think that the better solution would be storing secrets in KMS and decrypting them inside lambda during cold start. We could do that with our handler function form stdlib.

@mthenw
Copy link
Author

mthenw commented Nov 25, 2016

@nikgraf
Copy link
Contributor

nikgraf commented Nov 26, 2016

Awesome, will rewrite the plugin and the example to work with KMS

@mthenw
Copy link
Author

mthenw commented Nov 26, 2016

Awesome

@mikelax
Copy link

mikelax commented Mar 21, 2017

hey guys, I have just spent a good amount of time researching "best practice" handling of secret (ie. database passwords, etc) values in the serverless.yml file. After a lot of reading old tickets, (old) plugins, etc. I think that this plugin combined with the now built-in KMS at-rest encryption of Lambda Environment values is the way to go.

Is there any plan to get this plugin updated to use KMS instead of a password?

As an aside, I think that the general serverless documentation could stand to be updated to better reference Lambda environment variables and the meaning of "at-rest" encryption vs. encrypted values in code (ie. double encryption that will be happening). I would be willing to help update the docs in this regard.

@ashimaathri
Copy link

Hello, just wanted to know if this feature was being actively developed. Thanks!

@nikgraf
Copy link
Contributor

nikgraf commented Oct 16, 2017

Hey @mikelax @ashimaathri, I just merged a couple PRs and I'm about to make a release pretty soon. Unfortunately I don't have the bandwidth to integrate KMS into this plugin. You might have a closer look at this plugin if you are interested in KMS support https://github.com/SC5/serverless-kms-secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants