CreateBootstrapLogger doesn't work with non-static Logger

[gkinsman]

Hi there!

I'm kicking the tyres on CreateBootstrapLogger so that we can pull our log sink config from a secure store. To support parallel test running we don't use a static logger and instead inject it, but I don't see an override of UseSerilog/AddSerilog that accepts both an ILogger and a reconfiguration callback.

This code appears to only check to see if the static logger exists - should there perhaps be an overload that just accepts an ILogger and checks if it or the static logger is reloadable? Happy to add it if this is the right way to go :)

serilog-extensions-hosting/src/Serilog.Extensions.Hosting/SerilogServiceCollectionExtensions.cs

Lines 141 to 144 in 52f29a6

	#if !NO_RELOADABLE_LOGGER
	var reloadable = Log.Logger as ReloadableLogger;
	var useReload = reloadable != null && !preserveStaticLogger;
	#else

[nblumhardt]

Thanks for the note, @gkinsman! Sorry about the slow reply - just got back from a short vacation :-)

I might need a bit more context around what your test code looks like, I'm not sure I can really wrap my head around the scenario.

Just to try to fill in the picture - if you have an ILogger already in hand, could you (for example) try casting it to ReloadableLogger and call Reload yourself, before passing it through to AddSerilog?

[nblumhardt]

Closing this one as stale, hope you were able to figure out a solution.