Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement async batching via queue #12

Closed
augustoproiete opened this issue Aug 8, 2021 · 1 comment · Fixed by #14
Closed

Implement async batching via queue #12

augustoproiete opened this issue Aug 8, 2021 · 1 comment · Fixed by #14
Labels
enhancement New feature or request
Milestone

Comments

@augustoproiete
Copy link
Member

Currently each log entry is immediately written to the RichTextBox control when writes occur on the main thread, or immediately scheduled to be written to the RichTextBox control in the main UI thread via BeginInvoke otherwise.

This sometimes can cause the UI to become unresponsive when writing a large number of messages at the same time.

We should instead write messages to an in-memory queue that is consumed by a background worker on a separate thread, and implement batching and backpressure controls.

@augustoproiete
Copy link
Member Author

The Notepad sink has a very similar need thus whatever approach is implemented there can probably be copied to this sink and vice-versa.

@augustoproiete augustoproiete linked a pull request Oct 18, 2021 that will close this issue
@augustoproiete augustoproiete added this to the v1.1.0 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant