Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Pre-release versions show up as an "X" by default #151

Open
kotx opened this issue Oct 31, 2021 · 4 comments
Open

Pre-release versions show up as an "X" by default #151

kotx opened this issue Oct 31, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kotx
Copy link

kotx commented Oct 31, 2021

Describe the bug
Pre-release versions will show up as an "X" despite being newer than the latest releases, unless crates.listPreReleases is true. However, this config setting also lists pre-release versions in the version list, which may not be desired.

To Reproduce
Steps to reproduce the behavior:

  1. Use a RC or beta version of a crate like rocket 0.5.0-rc.1
  2. See the "X" in Cargo.toml
  3. Set crates.listPreReleases to true
  4. See the absence of the "X"

Expected behavior
Pre-release versions should not error even when crates.listPreReleases is set to false.

Screenshots

image
image

Desktop (please complete the following information):

  • OS: Windows 11
  • Version 21H2 (22000.282)
@msdrigg
Copy link
Contributor

msdrigg commented Nov 1, 2021

I would agree especially because the settings flag is global. This makes it difficult to use everywhere because some projects I am using pre-releases but others I dont.

Maybe it would be possible to have pre-releases marked with a yellow warning or something similar when the allow-pre-release setting is turned off. (And a similar warning when not using pre-releases when the setting is turned on).

I know this isn’t exactly what you are asking for, but would this resolve your issue?

@kotx
Copy link
Author

kotx commented Nov 1, 2021

That looks good to me!

@serayuzgur serayuzgur self-assigned this Jan 3, 2022
@serayuzgur serayuzgur added the enhancement New feature or request label Jan 3, 2022
@serayuzgur serayuzgur added this to the 0.5.11 milestone Jan 3, 2022
@0PandaDEV
Copy link

Any updates on this, it really annoys me.

@serayuzgur
Copy link
Owner

we are working on an update, all parsing etc refactored. So please lets deal all with these after the new release. It will be easier to patch things up after refactor.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants