Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation about signal handlers #260

Open
brianchhun opened this issue May 30, 2017 · 0 comments
Open

Incorrect documentation about signal handlers #260

brianchhun opened this issue May 30, 2017 · 0 comments

Comments

@brianchhun
Copy link

There are a couple pieces of documentation that describe how a worker will respond to a given signal, but these look like they need to be updated since the signal handling was refactored some time ago.

For example, in the README, it says "the child process supports the USR2 signal, whch causes it to dump its current backtrace."but it looks like USR2 will actually pause the process.

Also, deeper in the code, where the signal handlers are installed, is another set of descriptions for each signal (https://github.com/seomoz/qless/blob/master/lib/qless/worker/base.rb#L68). HUP is said to "Print current stack to log and continue", but I can't find the code that does such a thing, and the default, which is set in the initializer, appears to be a no-op (https://github.com/seomoz/qless/blob/master/lib/qless/worker/base.rb#L25).

Is it possible to fix the comments or remove them outright to avoid further confusion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant