Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-redis-info.rb should support crit + warn values for key #13

Open
majormoses opened this issue Feb 4, 2016 · 6 comments
Open

check-redis-info.rb should support crit + warn values for key #13

majormoses opened this issue Feb 4, 2016 · 6 comments

Comments

@majormoses
Copy link
Member

redis info has a wealth of useful metrics which could be monitored such as blocked_clients, evicted keys, rejected connections, etc.

I would be willing to work on putting together a pr and want some feedback on how I envision it to work.

if -K and -V are supplied it would check that the value matched

if -w || -c are supplied then it would ignore any -V value supplied (if any) and do a check to see if it is greater or equal to.

we could also have a -W || -C to check under

alternatively we could use -w || -c and a -g ||-l flag to determine above or below thresholds

@analytically
Copy link

👍

@majormoses
Copy link
Member Author

@analytically which approach would you prefer? using -c/-C || -w/-W or using the traditional -w/-c with a -/l/-g ?

@analytically
Copy link

-c/-C || -w/-W and a version bump (could you also describe it with examples in the README.md?)!

@majormoses
Copy link
Member Author

sure I will probably get to this early next week

@majormoses
Copy link
Member Author

majormoses commented Apr 5, 2016

just an update, sorry I am not using redis anymore at my workplace so this has not been a priority. I still plan on doing it, though it may be a while.

@analytically
Copy link

Ok thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants