Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify alert level in check-ports.rb #64

Open
thisiskseniab opened this issue Dec 11, 2017 · 2 comments
Open

Add ability to specify alert level in check-ports.rb #64

thisiskseniab opened this issue Dec 11, 2017 · 2 comments

Comments

@thisiskseniab
Copy link

check-ports.rb is a great tool, but it would be great to have an ability to specify "warning" as opposed to "critical" alert level for it, similarly as in check-ports-bind.rb and check-ports-nmap.rb.

@Evesy
Copy link
Contributor

Evesy commented Apr 16, 2018

Happy to put in a PR for this one as I'd like this too, looks like it originally existed but got lost at some point: 2d5d981

@majormoses If you could spare a moment, I can't figure out what unless config[:crit_message] is for here https://github.com/sensu-plugins/sensu-plugins-network-checks/blob/master/bin/check-ports.rb#L102 -- Seems like it may be redundant but wanted to double check before I put something together

@majormoses
Copy link
Member

@Evesy sorry this got lost in the sea of my github notifications. Ya that needs to be removed, I am not sure its worth the git archaeology to determine when, where, and why it changed lets just remove it.

If we were to implement a new option we would probably want it to be for a specific condition rather than catch all as not all errors are equal. For example we have one for redis for connection failures here: https://github.com/sensu-plugins/sensu-plugins-redis/blob/3.0.1/lib/redis_client_options.rb#L71-L75 as depending on the check it has a different meaning. If the check is meant to determine the health of redis you probably want that as a crit where other places you might want an unknown as you already have the crit from the one check and can help with improving the signal to noise ratio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants