Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This plugin is not consistent with many of the practices followed by most plugins #175

Open
8 tasks
majormoses opened this issue Jul 7, 2017 · 4 comments
Open
8 tasks

Comments

@majormoses
Copy link
Member

majormoses commented Jul 7, 2017

I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:

  • changelog does not follow the same format
  • the tags are all using the silly v$VERSION. Anyways not trying to start a religious war here, just pointing out areas in where there are differences and we should standardize where possible. As this is the outlier in 180+ plugins I vote we make the change here and not force a lot of extra work on converting everything over.
  • version is not broken out into its own file and is not setup the same way
  • does not have the standard travis config
  • does not auto deploy to rubygems on tag
  • does not have our standard Rakefile
  • does not have our standard rubocop config
  • sensu plugins user does not have access to push to rubygems. IMHO if you can merge there is no reason to not allow releasing.

I am sure there are plenty others...

@portertech
Copy link
Contributor

These all seem like reasonable suggestions. It is important to remember that this library is not a plugin, but the very backbone of every Sensu community plugin, and its practices may differ due to its very nature.

@majormoses
Copy link
Member Author

Agreed that it is different and does not need to be in 100% alignment but none of these things that were brought up seem plugin specific.

@majormoses
Copy link
Member Author

only one I see that might be different would be added rake tasks and a possibly modified rubocop config.

@luisdavim
Copy link

Hi, I've just opened #177 that addresses the rubocop part, the configuration I've added is not exactly the same as the one in the skel plugin but it's a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants