You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:
changelog does not follow the same format
the tags are all using the silly v$VERSION. Anyways not trying to start a religious war here, just pointing out areas in where there are differences and we should standardize where possible. As this is the outlier in 180+ plugins I vote we make the change here and not force a lot of extra work on converting everything over.
version is not broken out into its own file and is not setup the same way
does not have the standard travis config
does not auto deploy to rubygems on tag
does not have our standard Rakefile
does not have our standard rubocop config
sensu plugins user does not have access to push to rubygems. IMHO if you can merge there is no reason to not allow releasing.
I am sure there are plenty others...
The text was updated successfully, but these errors were encountered:
These all seem like reasonable suggestions. It is important to remember that this library is not a plugin, but the very backbone of every Sensu community plugin, and its practices may differ due to its very nature.
Hi, I've just opened #177 that addresses the rubocop part, the configuration I've added is not exactly the same as the one in the skel plugin but it's a start.
I see several things just looking around that we should change to bring it more inline with the way that all the other plugins are doing various things these are what I found when doing a release:
v$VERSION
. Anyways not trying to start a religious war here, just pointing out areas in where there are differences and we should standardize where possible. As this is the outlier in 180+ plugins I vote we make the change here and not force a lot of extra work on converting everything over.I am sure there are plenty others...
The text was updated successfully, but these errors were encountered: