Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load$ does not execute when query is null #44

Open
rjrodger opened this issue May 18, 2017 · 0 comments
Open

load$ does not execute when query is null #44

rjrodger opened this issue May 18, 2017 · 0 comments

Comments

@rjrodger
Copy link
Contributor

in make-entity.js:

  // empty query gives empty result
  if (q == null) {
    return cb()
  }

Is this correct? It means a role:entity,cmd:load does not get sent - and this is surprising as it removes 1-1 mapping with convenience API

msg should probably be sent even with null query for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjrodger