Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Sendgrid http client library to use latest apache http client 5 #147

Open
ahrooran-r opened this issue May 22, 2024 · 3 comments · May be fixed by #148
Open

Bump Sendgrid http client library to use latest apache http client 5 #147

ahrooran-r opened this issue May 22, 2024 · 3 comments · May be fixed by #148

Comments

@ahrooran-r
Copy link

This latest version of sendgrid does not support apache http client 5.
I saw another issue where you are trying to use JDK specific http libraries.
However, its been in stale since 2016 and last comment during 2022 also has no useful updates.

Could you please bump the library to use Http Client 5 at least?
https://mvnrepository.com/artifact/org.apache.httpcomponents.client5/httpclient5
@jkosternl
Copy link

Yes, for our project https://github.com/frankframework/frankframework we are using SendGrid as well, which uses this java-http-client which depends on the old org.apache.httpcomponents:httpclient:4.*.

@ryantomlinson95 ryantomlinson95 linked a pull request Sep 5, 2024 that will close this issue
Open
8 tasks
@ryantomlinson95
Copy link

I raised a PR to bump the library to use httpclient5, since we use SendGrid in our project that we're upgrading to httpclient5.

@jkosternl
Copy link

Great job @ryantomlinson95 👍🏻
I hope the maintainers can proceed with your changes and merge it and release a new version.

@ryantomli ryantomli mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Upgrading java-http-client to use apache httpclient5 ryantomlinson95/java-http-client
3 participants
@ryantomlinson95 @jkosternl @ahrooran-r