Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext-electron package shouldn't break applications while running in a browser #13

Open
savelee opened this issue Nov 24, 2016 · 0 comments

Comments

@savelee
Copy link

savelee commented Nov 24, 2016

When requiring/mixin ext-electron packages within a current Ext JS application, it shouldn't break when running in a browser. Instead it should check if running in electron, before loading native stuff.

I solved it by adding to Manager.js, Dialog.js, FilePicker.js, FolderField.js the following check:

  if(window && window.process) {
   // current electron implementation
  } else {
     Ext.define('Ext.electron.Dialog',  {});
 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant