Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to implement #1

Open
6 of 10 tasks
doloresgarcia opened this issue Jul 17, 2023 · 3 comments
Open
6 of 10 tasks

Things to implement #1

doloresgarcia opened this issue Jul 17, 2023 · 3 comments
Assignees

Comments

@doloresgarcia
Copy link
Collaborator

doloresgarcia commented Jul 17, 2023

Model features:

  • Obtain number of hits and true particles per event distribution (2d histogram) and mean and variance [Gregor]
  • Adding particle ID in the loss/model (see comments below) [Gregor; change to entire cluster pooling instead of the center node]
  • check if the energy of the particle matches the energy of the hits that link to the particle and correct it [Gregor]
  • train model gravnet, add track p as an input
  • also check if the model would be best if the E pred was calculated from the sum of the particles inside the cluster.
  • check if the loss function_E with the log works better (therefore without the 20 factor in the overall loss)
  • implement inference by removing hits that have been already associated as in procedure 2 of the end to end paper

Plotting:

  • visualize hits embedding space [Gregor]
  • what hits is it picking as cluster center
  • implement the plots, per type of particle (as in the paper) [Gregor]
@gregorkrz gregorkrz self-assigned this Jul 17, 2023
@doloresgarcia
Copy link
Collaborator Author

Note: currently the clustering is implemented as x_alpha (so not doing the mean of the particles in the cluster) this could also be done but may be worth it to keep the simple approach for now

@doloresgarcia
Copy link
Collaborator Author

About adding particle ID: this can not be regressed directly because it should be obtained from the cluster.
Options:

  • to pull the clusters and then regress 1 output for each subgraph
  • to do some aggregation from per hit regression (this is more sloppy)

@doloresgarcia
Copy link
Collaborator Author

doloresgarcia commented Jul 28, 2023

  • higher q value [0.3] EASY
  • sample different points in the class and add that to the loss Gregor
  • Take out the batchnom/dropout. EASY NOW
  • try other networks Dolo
  • batchnorm before the output layer. NOW
  • plot the gravnet clustering space Dolo
  • Option to start with the physical space [NOT FOR NOW]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants