Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest version of websockets has breaking changes that impact CDP Mode #3251

Closed
mdmintz opened this issue Nov 9, 2024 · 2 comments · Fixed by #3252
Closed

Latest version of websockets has breaking changes that impact CDP Mode #3251

mdmintz opened this issue Nov 9, 2024 · 2 comments · Fixed by #3252
Assignees
@mdmintz
Labels
Fun Something big happened / (maybe some sarcasm) requirements UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode

Comments

@mdmintz
Copy link
Member

mdmintz commented Nov 9, 2024

Latest version of websockets has breaking changes that impact CDP Mode

Big changes between https://pypi.org/project/websockets/13.1/ and https://pypi.org/project/websockets/14.0/

Read all about it here: https://websockets.readthedocs.io/en/stable/howto/upgrade.html

Need to make some changes in SeleniumBase to keep everything working in CDP Mode.
@mdmintz mdmintz added requirements UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode Fun Something big happened / (maybe some sarcasm) labels Nov 9, 2024
@mdmintz mdmintz self-assigned this Nov 9, 2024
@mdmintz mdmintz mentioned this issue Nov 9, 2024
Merged
@mdmintz
Copy link
Member Author

mdmintz commented Nov 9, 2024

This was resolved in 4.32.9 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.32.9

@mdmintz
Copy link
Member Author

mdmintz commented Nov 12, 2024

This fixes ultrafunkamsterdam/undetected-chromedriver#2075 and ultrafunkamsterdam/undetected-chromedriver#2069.

@afeuerstein afeuerstein mentioned this issue Nov 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdmintz mdmintz

Labels
Fun Something big happened / (maybe some sarcasm) requirements UC Mode / CDP Mode Undetected Chromedriver Mode / CDP Mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CDP Mode - Patch 9 seleniumbase/SeleniumBase
1 participant
@mdmintz