From 895e86f39626f37c980dfb6db0bd8710e1e33b90 Mon Sep 17 00:00:00 2001
From: w41ter <w41ter.l@gmail.com>
Date: Fri, 27 Sep 2024 17:00:27 +0800
Subject: [PATCH] Fix create dropped view

Try create a view but already dropped in the upstream cluster
---
 pkg/ccr/job.go                                | 14 ++++++++++
 .../test_sync_view_drop_create.groovy         | 28 +++++++++++++++++++
 2 files changed, 42 insertions(+)

diff --git a/pkg/ccr/job.go b/pkg/ccr/job.go
index 6b7bb990..be3eb89f 100644
--- a/pkg/ccr/job.go
+++ b/pkg/ccr/job.go
@@ -1383,6 +1383,20 @@ func (j *Job) handleCreateTable(binlog *festruct.TBinlog) error {
 		return err
 	}
 
+	log.Infof("walter get table name by id %d name '%s'", createTable.TableId, srcTableName)
+
+	if len(srcTableName) == 0 {
+		// The table is not found in upstream, try read it from the binlog record,
+		// but it might failed because the `tableName` field is added after doris 2.0.3.
+		srcTableName = strings.TrimSpace(createTable.TableName)
+		if len(srcTableName) == 0 {
+			return xerror.Errorf(xerror.Normal, "the table with id %d is not found in the upstream cluster, create table: %s",
+				createTable.TableId, createTable.String())
+		}
+		log.Infof("the table id %d is not found in the upstream, use the name %s from the binlog record",
+			createTable.TableId, srcTableName)
+	}
+
 	var destTableId int64
 	destTableId, err = j.destMeta.GetTableId(srcTableName)
 	if err != nil {
diff --git a/regression-test/suites/db-sync-view-drop-create/test_sync_view_drop_create.groovy b/regression-test/suites/db-sync-view-drop-create/test_sync_view_drop_create.groovy
index ba58c7b9..965efbc2 100644
--- a/regression-test/suites/db-sync-view-drop-create/test_sync_view_drop_create.groovy
+++ b/regression-test/suites/db-sync-view-drop-create/test_sync_view_drop_create.groovy
@@ -46,6 +46,8 @@ suite("test_sync_view_drop_create") {
 
     def suffix = UUID.randomUUID().toString().replace("-", "")
     def tableDuplicate0 = "tbl_duplicate_0_${suffix}"
+    sql """ DROP VIEW IF EXISTS view_test_${suffix} """
+    sql """ DROP VIEW IF EXISTS view_test_1_${suffix} """
     createDuplicateTable(tableDuplicate0)
     sql """
         INSERT INTO ${tableDuplicate0} VALUES
@@ -97,5 +99,31 @@ suite("test_sync_view_drop_create") {
     assertTrue(helper.checkSelectTimesOf("SELECT * FROM ${tableDuplicate0}", 8, 50))
     def view_size = target_sql "SHOW VIEW FROM ${tableDuplicate0}"
     assertTrue(view_size.size() == 1);
+
+    // pause and create again, so create view will query the upstream to found table name.
+    helper.ccrJobPause()
+
+    sql """
+        CREATE VIEW view_test_1_${suffix} (k1, name,  v1)
+        AS
+        SELECT user_id as k1, name,  SUM(age) FROM ${tableDuplicate0}
+        GROUP BY k1,name;
+    """
+    sql """ DROP VIEW view_test_1_${suffix} """
+
+    helper.ccrJobResume()
+
+    // insert will be sync.
+    sql """
+        INSERT INTO ${tableDuplicate0} VALUES
+            (6, "Zhangsan", 31),
+            (5, "Ava", 20);
+        """
+    sql "sync"
+
+    assertTrue(helper.checkSelectTimesOf("SELECT * FROM ${tableDuplicate0}", 10, 50))
+    view_size = target_sql "SHOW VIEW FROM ${tableDuplicate0}"
+    assertTrue(view_size.size() == 1);
+
 }