Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to a GitHub App #58

Open
Malix-Labs opened this issue Feb 15, 2024 · 4 comments
Open

Convert to a GitHub App #58

Malix-Labs opened this issue Feb 15, 2024 · 4 comments

Comments

@Malix-Labs
Copy link

Malix-Labs commented Feb 15, 2024

See GitHub Docs - Choosing between a GitHub App or a personal access token

@seladb
Copy link
Owner

seladb commented Feb 20, 2024

@Malix-off I'm not sure StarTrack is suitable to be a GitHub App because it doesn't have a backend. It has no way to store the private key and the client secret. Also - is it possible for a user to choose not to register to the app once they go to StarTrack?

@Malix-Labs
Copy link
Author

Hello @seladb!
I think it would be possible to make it without a backend with a few tweaks, I'm currently experimenting that on my app

Once they go to startrack, they will be logged in by default, but you could still use the GitHub API without login, as it is currently possible

@seladb
Copy link
Owner

seladb commented Feb 23, 2024

@Malix-off if it works I think it could be a nice addition to StarTrack! Once you finish experimenting on your app, could you share your findings?

Maybe you can consider implementing it for StarTrack too 🙂

@Malix-Labs
Copy link
Author

I have quite a few things to work on before that, but when I will do it, I will report back!
There's no rush anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants