Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

template/koa-rest-api: koa-bodyparser => @koa/bodyparser #1605

Merged
merged 4 commits into from
Sep 29, 2024
Merged

template/koa-rest-api: koa-bodyparser => @koa/bodyparser #1605

merged 4 commits into from
Sep 29, 2024

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jul 2, 2024

@72636c 72636c requested a review from a team as a code owner July 2, 2024 03:54
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 522a7bb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@72636c
Copy link
Member Author

72636c commented Jul 2, 2024

Do we want a patch for this?

@AaronMoat
Copy link
Contributor

I'd hold off on the patch until koajs/bodyparser#161 settles, personally

@samchungy
Copy link
Contributor

Should we renovate replace it?

samchungy
samchungy reviewed Jul 2, 2024
View reviewed changes
template/koa-rest-api/package.json
@@ -33,8 +33,8 @@
},
"devDependencies": {
"@types/chance": "^1.1.3",
"@types/co-body": "^6.1.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To unskipLibCheck, we need to pull in the transitive type dep 🥲

https://github.com/koajs/bodyparser/blob/031348a2d469dd288dc21cd10d8de280d9936f2c/package.json#L49

https://github.com/koajs/bodyparser/blob/031348a2d469dd288dc21cd10d8de280d9936f2c/src/body-parser.types.ts#L1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 worth upstreaming?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

koajs/bodyparser#164

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samchungy 🙇

@AaronMoat
Copy link
Contributor

🤔 I think @koa/bodyparser bundles with types

@72636c 72636c enabled auto-merge (squash) September 29, 2024 23:51
@72636c 72636c merged commit 8efb513 into main Sep 29, 2024
16 checks passed
@72636c 72636c deleted the koa-bodyparser branch September 29, 2024 23:52
@seek-oss-ci seek-oss-ci mentioned this pull request Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samchungy samchungy samchungy left review comments

@AaronMoat AaronMoat AaronMoat approved these changes

@tadhglewis tadhglewis tadhglewis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@72636c @AaronMoat @samchungy @tadhglewis