You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sendHand uses seconds where all other send functions (sendLifter, sendModelAngles, sendTrajectory) uses milliseconds. This is mixing units. It should be either all seconds or all milliseconds.
there is also a mixed unit with sending grasp angles from command line? (from code, it is radian, but from command line it is degrees? this should be both radian?)
In terms of send units, ROS standard is seconds. I think we need a discussion on which units to use. (perhaps use seconds in the next release and for now all should be milliseconds?)
Also, which ever unit we use, there should be a warning when the passed argument is too small for milliseconds, or too large for seconds. (obviously, sending 3000 seconds is not intended, 3.0 milliseconds is also not intended, 50 could be seconds or milliseconds but most likely milliseconds)
The text was updated successfully, but these errors were encountered:
sendHand uses seconds where all other send functions (sendLifter, sendModelAngles, sendTrajectory) uses milliseconds. This is mixing units. It should be either all seconds or all milliseconds.
there is also a mixed unit with sending grasp angles from command line? (from code, it is radian, but from command line it is degrees? this should be both radian?)
In terms of send units, ROS standard is seconds. I think we need a discussion on which units to use. (perhaps use seconds in the next release and for now all should be milliseconds?)
Also, which ever unit we use, there should be a warning when the passed argument is too small for milliseconds, or too large for seconds. (obviously, sending 3000 seconds is not intended, 3.0 milliseconds is also not intended, 50 could be seconds or milliseconds but most likely milliseconds)
The text was updated successfully, but these errors were encountered: