Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixed units in aero_std #350

Open
sasabot opened this issue May 26, 2018 · 0 comments
Open

mixed units in aero_std #350

sasabot opened this issue May 26, 2018 · 0 comments

Comments

@sasabot
Copy link
Collaborator

sasabot commented May 26, 2018

sendHand uses seconds where all other send functions (sendLifter, sendModelAngles, sendTrajectory) uses milliseconds. This is mixing units. It should be either all seconds or all milliseconds.

there is also a mixed unit with sending grasp angles from command line? (from code, it is radian, but from command line it is degrees? this should be both radian?)

In terms of send units, ROS standard is seconds. I think we need a discussion on which units to use. (perhaps use seconds in the next release and for now all should be milliseconds?)
Also, which ever unit we use, there should be a warning when the passed argument is too small for milliseconds, or too large for seconds. (obviously, sending 3000 seconds is not intended, 3.0 milliseconds is also not intended, 50 could be seconds or milliseconds but most likely milliseconds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant