Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[importer] disable requirement for entity names to be unique #826

Open
tlongers opened this issue Nov 24, 2023 · 2 comments
Open

[importer] disable requirement for entity names to be unique #826

tlongers opened this issue Nov 24, 2023 · 2 comments

Comments

@tlongers
Copy link
Member

In some cases, there are different values in person:id:admin for the same string in person:name string:

person:id:admin person:name
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Moe Aung
404df6f2-c490-4605-8e8b-7ddb8ec75f7e Moe Aung

The sfm-cms importer is conservative, and flags these as a possible data entry error:

"Got multiple UUID values for person name"

However, the data are correct: there are two distinct people with the same name. I think it may be a legacy of the period before we used uuids as identifiers but used names instead.

I think this is where it is called:

self.log_conflicts(entity_type, entity_map, transpose=True)

So this particular check should be disabled in the importer.

For completion, the check that sholud be retained retain is the reverse of the above - those cases where there is variation in the string in person:name, but the uuid in person:id:admin remains the same:

person:id:admin person:name
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Moe Aung
7d3f6ecf-5cd3-4c13-a313-9033357665f6 Davy Jones

This indicates an error that we want to know about.

@tonysecurityforcemonitor double check my reasoning here please.

@hancush
Copy link

hancush commented Dec 4, 2023

FWIW, this check does not prevent import, it simply logs both instances, because in the past, the some person has been split into two via different IDs.

@tlongers
Copy link
Member Author

Thanks Hannah, that's great to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants