Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Areas of operation are sometimes duplicated on organization detail pages #774

Open
hancush opened this issue Aug 31, 2021 · 1 comment
Open
Labels

Comments

@hancush
Copy link

hancush commented Aug 31, 2021

Reference link not available.

I'm looking into this. Possibly related to #697?

@hancush hancush added the bug label Aug 31, 2021
@hancush hancush changed the title Superior officers and subordinates are sometimes duplicated on person detail pages Areas of operation are sometimes duplicated on person detail pages Aug 31, 2021
@hancush hancush changed the title Areas of operation are sometimes duplicated on person detail pages Areas of operation are sometimes duplicated on organization detail pages Aug 31, 2021
@hancush
Copy link
Author

hancush commented Sep 1, 2021

This is occurring because we use the first and last cited dates to sort areas of operation, and a particular area can have multiple first/last cited dates, causing areas having more than one of either date to appear multiple times on the page.

I have a patch to reimplement the custom sort, such that the duplicates are removed, however we don't have a good way to control which start/end dates are displayed, which makes the sort appear nonsensical for AOOs having more than one of either date.

@tlongers How wedded are we to sorting AOO by start/end date? Would falling back to sorting by area name be acceptable, or is it worth investing the time (at least another few hours, I reckon) make date sort and display work correctly?

NVM, I refactored sort to prevent dupes, then I took a walk and figured out a straightforward way to fix date display, as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant