bleno and noble

[mprokopowicz]

Why are bleno and noble packages kept in lib dir? Are they modified somehow?
If not then I want to suggest adding them package.json as dependencies.

[securing]

Yes, they are modified.

Noble:

We need raw hex values of BLE advertisements: EIR broadcasted from device, and the EIR "scan response". Noble gives us only parsed versions, and in many cases it is not enough to "clone" original device 1:1. My PR to noble:
noble/noble#426
Similar discussion:
noble/noble#436

I would be happy to depend on unmodified noble. I was planning to give a try a trick by Damien Cauquil in btlejuice:
https://github.com/DigitalSecurity/btlejuice/blob/a0be08e0a05f6946b8c18a5ffa124ff975e0662c/proxy.js#L185-#L191
https://github.com/DigitalSecurity/btlejuice/blob/a0be08e0a05f6946b8c18a5ffa124ff975e0662c/proxy.js#L213-#L227
I haven't been able to test it yet.

Secondly, I recently added long write support for noble:
noble/noble#452
This feature is not yet pushed here in GATTacker's lib/noble. But if the PR to noble won't be accepted, this would be another reason to keep fork.

Bleno:

Because of mobile OS GATT cache we need to specify exact handle numbers. And also we don't need default bleno services.
Discussion (with detailed description):
noble/bleno#224