Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regarding SCP 7.10 #19

Open
htadashi opened this issue Jul 6, 2022 · 1 comment
Open

Regarding SCP 7.10 #19

htadashi opened this issue Jul 6, 2022 · 1 comment

Comments

@htadashi
Copy link

htadashi commented Jul 6, 2022

# Description
7.10 Verify that the external keyword is used for functions that can be called externally only to save gas.

Only changing to external will not save gas. The arguments parameters also must be changed from memory to calldata:
https://ethereum.stackexchange.com/a/107939/4630

@damianrusinek
Copy link
Contributor

Thanks for the link, we will have a look on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants