From 12883131e26c277cdb3f88653112973e41b07c94 Mon Sep 17 00:00:00 2001 From: Gaurav Munjal Date: Thu, 2 Dec 2021 10:02:53 -0500 Subject: [PATCH] address feedback --- package.json | 2 +- tests/dummy/config/targets.js | 28 +++++++++++++++++++--------- 2 files changed, 20 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index 13e8d24..c934bf5 100644 --- a/package.json +++ b/package.json @@ -133,7 +133,7 @@ "configPath": "tests/dummy/config", "demoURL": "https://secondstreet.github.io/ember-material-components-web/", "versionCompatibility": { - "ember": ">=6.0" + "ember": ">=3.16.0" } }, "volta": { diff --git a/tests/dummy/config/targets.js b/tests/dummy/config/targets.js index 831a25c..7d305cb 100644 --- a/tests/dummy/config/targets.js +++ b/tests/dummy/config/targets.js @@ -1,11 +1,21 @@ 'use strict'; -const browsers = [ - 'last 2 Chrome versions', - 'last 1 Firefox versions', - 'last 1 Safari versions', - 'last 1 Edge versions', -]; +let browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions']; + +const isCI = Boolean(process.env.CI); +const isProduction = process.env.EMBER_ENV === 'production'; +const isOldScenario = process.env.EMBER_TRY_SCENARIO === 'ember-lts-3.16'; + +if (isCI || isProduction) { + browsers = [ + 'last 3 Chrome versions', + 'last 3 iOS versions', + 'last 2 ChromeAndroid versions', + 'last 3 Firefox versions', + 'last 2 Safari versions', + 'last 3 Edge versions', + ]; +} // Ember's browser support policy is changing, and IE11 support will end in // v4.0 onwards. @@ -18,9 +28,9 @@ const browsers = [ // const isCI = Boolean(process.env.CI); // const isProduction = process.env.EMBER_ENV === 'production'; // -// if (isCI || isProduction) { -// browsers.push('ie 11'); -// } +if (isProduction || isOldScenario) { + browsers.push('ie 11'); +} module.exports = { browsers,