Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in the formula of Bichon and Ranjan criteria, other points and question #828

Open
mdelozzo opened this issue Mar 8, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@mdelozzo
Copy link

mdelozzo commented Mar 8, 2024

Thanks for this nice package! I've got a few points.

The LaTeX formula for Bichon and Ranjan criteria seems wrong. In Equation (31) of the citer paper, we can read the conditionned GP $\xi(x)$ instead of its mean $m(x)$, as currently written in the docstring.

Other points:

  • the rendering of the AEI is broken; the LaTeX line should be surrounded by empty lines in the docstring.
  • $f$ is both the function to approximate and the conditionned GP in the documentation; two separate notations would be clearer,
  • a section about notations would be useful, and perhaps a page listing the criteria (in addition to the API pages).

Question: is it possible to use specific basis functions for the GP mean?

@uri-granta
Copy link
Collaborator

Thank you for spotting and raising these!

And yes, it is possible to use specific basis functions: there are various built-in functions and you can define your own, as described at https://gpflow.github.io/GPflow/develop/notebooks/getting_started/mean_functions.html.

@uri-granta uri-granta added the documentation Improvements or additions to documentation label Mar 25, 2024
@uri-granta
Copy link
Collaborator

@hstojic could you please check the bichon_ranjan_criterion docstring issue mentioned above?

@hstojic
Copy link
Collaborator

hstojic commented Mar 25, 2024

ok, I'll check it out - while we are at it, @uri-granta probability_below_threshold also has a broken equation, and there is something weird in batch_expected_improvement with _delta method docstring

@mdelozzo
Copy link
Author

Thanks @uri-granta for your link. I'll take a closer look at the API documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants