From 831db9a8af87ee2ce9231652d8da7c50941b98a7 Mon Sep 17 00:00:00 2001
From: "jan.nijtmans" <nijtmans@users.sourceforge.net>
Date: Thu, 29 Sep 2022 06:45:20 +0000
Subject: [PATCH 1/2] Remove "unknown" constraint, since it now works

---
 tests/lseq.test | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/lseq.test b/tests/lseq.test
index 48adfa0461ea..45e3cd335068 100644
--- a/tests/lseq.test
+++ b/tests/lseq.test
@@ -65,7 +65,7 @@ test lseq-1.10 {integer lseq with step} {
     lseq 1 to 10 by 2
 } {1 3 5 7 9}
 
-test lseq-1.11 {error case: increasing wrong step direction} knownBug {
+test lseq-1.11 {error case: increasing wrong step direction} {
     lseq 1 to 10 by -2
 } {}
 
@@ -113,7 +113,7 @@ test lseq-1.19 {too many arguments extra numeric value} -body {
     lseq 12 to 24 by 2 7
 } -returnCodes 1 -result {wrong # args: should be "lseq n ??op? n ??by? n??"}
 
-test lseq-1.20 {bug: wrong length computed} knownBug {
+test lseq-1.20 {bug: wrong length computed} {
     lseq 1 to 10 -1
 } {}
 
@@ -128,11 +128,11 @@ test lseq-1.22 {n n by -n} {
 #
 # Short-hand use cases
 #
-test lseq-2.2 {step magnitude} knownBug {
+test lseq-2.2 {step magnitude} {
     lseq 10 1 2 ;# this is an empty case since step has wrong sign
 } {}
 
-test lseq-2.3 {step wrong sign} {arithSeriesDouble knownBug} {
+test lseq-2.3 {step wrong sign} arithSeriesDouble {
     lseq 25. 5. 5 ;# ditto - empty list
 } {}
 
@@ -166,7 +166,7 @@ test lseq-2.10 {integer lseq with step} {
     lseq 1 10 2
 } {1 3 5 7 9}
 
-test lseq-2.11 {error case: increasing wrong step direction} knownBug {
+test lseq-2.11 {error case: increasing wrong step direction} {
     lseq 1 10 -2
 } {}
 
@@ -196,7 +196,7 @@ test lseq-2.17 {large numbers} arithSeriesDouble {
 
 # Covered: {10 1 2 } {1 10 2} {1 10 -2} {1 1 1} {1 1 1} {-5 17 3}
 # Missing: {- - +} {- - -} {- + -} {+ - -} {- - +} {+ + -}
-test lseq-2.18 {signs} knownBug {
+test lseq-2.18 {signs} {
     list [lseq -10 -1 2] \
 	[lseq -10 -1 -1] \
 	[lseq -10 1 -3] \
@@ -390,7 +390,7 @@ test lseq-3.28 {lreverse bug in ArithSeries} {} {
     list $r $rr [string equal $r [lreverse $rr]]
 } {{-5 -2 1 4 7 10 13 16} {16 13 10 7 4 1 -2 -5} 1}
 
-test lseq-3.29 {edge case: negative count} knownBug {
+test lseq-3.29 {edge case: negative count} {
     lseq -15
 } {}
 
@@ -425,7 +425,7 @@ test lseq-4.2 {start expressions} {
 ##	lseq 1 to 10 by -2
 ##	# -> lseq: invalid step = -2 with a = 1 and b = 10
 
-test lseq-4.3 {TIP examples} knownBug {
+test lseq-4.3 {TIP examples} {
     set examples {# Examples from TIP-629
 	# --- Begin ---
 	lseq 10 .. 1

From 31eac27424d7d68812545a6204a2b2f0c02b4907 Mon Sep 17 00:00:00 2001
From: griffin <griffin>
Date: Thu, 29 Sep 2022 16:10:07 +0000
Subject: [PATCH 2/2] Fix bug-99e834bf33

---
 generic/tclExecute.c |  2 +-
 tests/lseq.test      | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/generic/tclExecute.c b/generic/tclExecute.c
index 5f29bfa9fc6d..fa0dfa2446ac 100644
--- a/generic/tclExecute.c
+++ b/generic/tclExecute.c
@@ -4938,7 +4938,7 @@ TEBCresume(
 
 	    /* Decode end-offset index values. */
 
-	    index = TclIndexDecode(opnd, length);
+	    index = TclIndexDecode(opnd, length-1);
 
 	    /* Compute value @ index */
 	    if (index >= 0 && index < length) {
diff --git a/tests/lseq.test b/tests/lseq.test
index e05b32d4f246..518a7bb2fdb9 100644
--- a/tests/lseq.test
+++ b/tests/lseq.test
@@ -489,9 +489,19 @@ test lseq-4.4 {lseq corner case} -body {
 	lappend res $s $e
     }
     eval $tcmd
+} -cleanup {
+    unset res
 } -result {0 10 1 {max length of a Tcl list exceeded} 1 {max length of a Tcl list exceeded} 0 10 0 2147483638}
 
 
+# Ticket 99e834bf33 - lseq, lindex end off by one
+
+test lseq-4.5 {lindex off by one} -body {
+    lappend res [eval {lindex [lseq 1 4] end}]
+    lappend res [eval {lindex [lseq 1 4] end-1}]
+} -result {4 3}
+
+
 # cleanup
 ::tcltest::cleanupTests
 return