Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mostly UI/navigation changes and minor fixes #28

Merged
merged 17 commits into from Dec 27, 2012
Merged

Mostly UI/navigation changes and minor fixes #28

merged 17 commits into from Dec 27, 2012

Conversation

ghost
Copy link

@ghost ghost commented Dec 27, 2012

Hope you like it ;)

$vw_vars['show_edit_link'] = true;
$vw_vars['list_column_families'] .= getHTML('columnfamily_details.php',$vw_vars);
$vw_vars['show_edit_link'] = true;
$vw_vars['list_column_families'] .= '<tr><td onclick="document.location.href=\'describe_columnfamily.php?keyspace_name=' . $keyspace_name . '&columnfamily_name=' . $vw_vars['columnfamily_name'] . '\'"><a href="describe_columnfamily.php?keyspace_name=' . $keyspace_name . '&columnfamily_name=' . $vw_vars['columnfamily_name'] . '">' . $vw_vars['columnfamily_name'] . '</a></td></tr>';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to create a view file for this and call getHTML() instead :)

@ghost
Copy link
Author

ghost commented Dec 27, 2012

that should do it

$vw_vars['show_edit_link'] = true;
$vw_vars['list_column_families'] .= getHTML('columnfamily_details.php',$vw_vars);
$vw_vars['show_edit_link'] = true;
$vw_vars['list_column_families'] .= '';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line seems useless ? :P

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, totally forgot that line

@sebgiroux
Copy link
Owner

Awesome, thanks again man!

sebgiroux pushed a commit that referenced this pull request Dec 27, 2012
Mostly UI/navigation changes and minor fixes
@sebgiroux sebgiroux merged commit d6d63a6 into sebgiroux:master Dec 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting editing a column value to '0' (without quotes) just deletes it
1 participant