From 2a959ed22baf024b54d8a49dc2e2c0c20888be84 Mon Sep 17 00:00:00 2001 From: Ryan Yappert Date: Thu, 12 Dec 2024 20:40:25 -0800 Subject: [PATCH] Reduce error logging when we can't find questScheduleIds known to be associated with pcap world manage quests. --- .../Characters/QuestManager.cs | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/Arrowgene.Ddon.GameServer/Characters/QuestManager.cs b/Arrowgene.Ddon.GameServer/Characters/QuestManager.cs index 351e2f6b4..31e927031 100644 --- a/Arrowgene.Ddon.GameServer/Characters/QuestManager.cs +++ b/Arrowgene.Ddon.GameServer/Characters/QuestManager.cs @@ -32,6 +32,15 @@ private QuestManager() private static Dictionary> gTutorialQuests = new Dictionary>(); private static Dictionary> gWorldQuests = new Dictionary>(); + /// + /// QuestScheduleIds that are requested as part of World Manage Quests from pcaps. + /// We know they can't be found, so don't audibly complain about them. + /// + private static readonly HashSet KnownBadQuestScheduleIds = new HashSet() + { + 25077, 43645, 43646, 47734, 47736, 47737, 47738, 47739, 49692, 77644, 151381, 208640, 233576, 259411, 259412, 287378, 315624 + }; + public static void LoadQuests(DdonGameServer server) { var assetRepository = server.AssetRepository; @@ -125,7 +134,11 @@ public static Quest GetQuestByScheduleId(uint questScheduleId) { if (!gQuests.ContainsKey(questScheduleId)) { - Logger.Error($"GetQuestByScheduleId: Invalid questScheduleId {questScheduleId}"); + if (!KnownBadQuestScheduleIds.Contains(questScheduleId)) + { + Logger.Error($"GetQuestByScheduleId: Invalid questScheduleId {questScheduleId}"); + } + return null; }