Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobx Proxy Configuration #421

Closed
korgon opened this issue Mar 22, 2022 · 1 comment · Fixed by #1229 or #1233
Closed

Mobx Proxy Configuration #421

korgon opened this issue Mar 22, 2022 · 1 comment · Fixed by #1229 or #1233
Assignees
Labels
type: feature New functionality
Milestone

Comments

@korgon
Copy link
Contributor

korgon commented Mar 22, 2022

Currently we are always disabling the use of proxy for browser compatibility. However now that we are building universal and modern bundles, we could potentially change this setting based on the current build. It would be worthwhile using proxies to make the exploration of the store data easier.

configureMobx({ useProxies: 'never' });

We would need our code to have some sort of awareness on which build is running (modern vs. universal). There a couple ideas on how we could identify the bundle below, but perhaps there is another yet to be thought of?

  1. Using webpack "defineplugin" (similar to what we do to get the current branch name) to then configure Mobx accordingly (maybe via a new setting)
  2. Leverage the polyfill (exported out of snap-preact) and used by universal.js to set a global variable or other flag that can be later picked up by Snap to then configure Mobx accordingly
@stale
Copy link

stale bot commented Sep 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No activity label Sep 18, 2022
@korgon korgon removed the stale No activity label Sep 19, 2022
@chrisFrazier77 chrisFrazier77 self-assigned this Mar 2, 2023
@korgon korgon removed the enhancement label May 5, 2023
@korgon korgon added this to the 1.0 milestone Nov 15, 2024
@korgon korgon added the type: feature New functionality label Nov 15, 2024
@chrisFrazier77 chrisFrazier77 self-assigned this Dec 17, 2024
@chrisFrazier77 chrisFrazier77 linked a pull request Dec 17, 2024 that will close this issue
@korgon korgon mentioned this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants