Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom ResultComponent CCP Selector and Prop Overrides #1218

Open
korgon opened this issue Dec 4, 2024 · 0 comments
Open

Custom ResultComponent CCP Selector and Prop Overrides #1218

korgon opened this issue Dec 4, 2024 · 0 comments
Assignees
Labels
critical Should be fixed ASAP type: bug Something isn't working

Comments

@korgon
Copy link
Contributor

korgon commented Dec 4, 2024

With templates the order of props merging prioritizes the overrides above all - which leads to a wonky scenario when attempting to provide props in custom ResultComponents. The ResultComponent sub-component props should take priority over overides, but currently do not.

For example, using the Price component, the symbol is unable to be changed due to Templates currency overrides within the Theme.

<Price symbol='***' value={core.price} />

Related... instead of adding names to component instances (as was suggested for being able to target the selector checkbox in screenshot) we should look to creating a method for selecting sub-components of custom result components.
Image

Currently it is not possible to select only components within a custom result component, but that will likely be needed.

Ideas:

  1. somehow allow for custom names in product cards (currently typing does not allow for this)
  2. wrapper component that adds to the treepath
@korgon korgon added this to the Snap Templates milestone Dec 4, 2024
@korgon korgon added critical Should be fixed ASAP type: bug Something isn't working labels Dec 4, 2024
@chrisFrazier77 chrisFrazier77 self-assigned this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical Should be fixed ASAP type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants