Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of results pages which can be returned, to try to deter bots #164

Open
m-i-l opened this issue Nov 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@m-i-l
Copy link
Contributor

m-i-l commented Nov 2, 2024

Bots regularly try to get crazy amounts of results simply by appending the page parameter, without actually checking if there are that many pages of results, wasting a lot of CPU resources in the process. For example, a bot has spent hours searching through 10s of 1000s of pages of results for the query "argos garden furniture habitat", via e.g. GET /search/?q=argos+garden+furniture+habitat&page=28802, despite there not being one single result for that query.

Really should return a 404 if the page parameter is above a certain value, e.g. 100, or at the very least not waste CPU time actually performing the search.

@m-i-l m-i-l added the enhancement New feature or request label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant