Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of upload_files task in playbooks #651

Open
lucbeaufils opened this issue Dec 6, 2024 · 0 comments
Open

Duplication of upload_files task in playbooks #651

lucbeaufils opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@lucbeaufils
Copy link
Contributor

Abstract
The upload_files var is use to copy file in the destination machine.
The same task is duplicate between centos, debian and yocto playbooks

Detailed Description
It would be better to add the task in a dedicated role to prevent the duplication in playbooks.

$ rg upload_files     
playbooks/seapath_setup_prerequisdebian.yaml
67:      with_items: "{{ upload_files }}"
69:        - upload_files is defined
78:      with_items: "{{ upload_files }}"
80:        - upload_files is defined

playbooks/seapath_setup_prerequisyocto.yaml
36:      with_items: "{{ upload_files }}"
38:        - upload_files is defined
47:      with_items: "{{ upload_files }}"
49:        - upload_files is defined

playbooks/seapath_setup_prerequiscentos.yaml
65:      with_items: "{{ upload_files }}"
67:        - upload_files is defined
76:      with_items: "{{ upload_files }}"
78:        - upload_files is defined

Work to be done
remove task from playbooks, create a role

@lucbeaufils lucbeaufils added the enhancement New feature or request label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant