Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt-in to remembering password #190

Closed
seansfkelley opened this issue May 10, 2021 · 1 comment
Closed

opt-in to remembering password #190

seansfkelley opened this issue May 10, 2021 · 1 comment

Comments

@seansfkelley
Copy link
Owner

Use a "remember me" checkbox. Tweak the phrasing/behavior of "Test Connection and Save", since it'll behave more like a normal login page.

On browser session start:

  • If the user opens the popup first, show a password prompt dialog.
  • If the user opens the settings page first, highlight the password field in some fashion.
  • If the user uses the context menu or clicks a magnet link first, use an error notification (maybe same code path as ConnectionFailure?).

Internally, preserve the auto-relogin behavior, but keep the password in memory.

This may have overlap with #7, since they both deal with temporary/in-memory authentication.

@seansfkelley
Copy link
Owner Author

Implemented in the commits up to an including 90bb4ea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant