Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only upgrade helm on change #22

Open
dberuben opened this issue Sep 1, 2023 · 3 comments
Open

feat: only upgrade helm on change #22

dberuben opened this issue Sep 1, 2023 · 3 comments
Milestone

Comments

@dberuben
Copy link
Contributor

dberuben commented Sep 1, 2023

Did I miss something?

(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm ls
NAME       	NAMESPACE	REVISION	UPDATED                              	STATUS  	CHART            	APP VERSION
helloworld1	default  	4       	2023-09-01 15:56:18.159761 +0200 CEST	deployed	hello-world-0.6.0
helloworld2	default  	4       	2023-09-01 15:56:18.115698 +0200 CEST	deployed	hello-world-0.6.0
(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm plugin list
NAME   	VERSION	DESCRIPTION
compose	1.2.0
apiVersion: 1.1

storage:
  name: mycompose
  type: local # default
  path: .hcstate # default

releases:
  helloworld1:
    chart: sikalabs/hello-world 
    values:
      replicas: 2
  helloworld2:
    chart: sikalabs/hello-world 
    values:
      replicas: 2
repositories:
  sikalabs: https://helm.sikalabs.io

@dberuben
Copy link
Contributor Author

dberuben commented Sep 1, 2023

Ok works for helm compose list

(☸|lspay-trial-eu-west-1:default)➜  helm-compose-test helm compose list
| Date             | Revision |
| ---------------- | -------- |
| 2023-09-01 16:03 |        1 |

I was hoping for helm ls be the same

@tuunit
Copy link
Member

tuunit commented Sep 1, 2023

@dberuben this is default helm behaviour. Which I wouldn't like to mess with as you might never know if the referenced chart or value files have changed.

A release version is an incremental revision. Every time an install, upgrade, or rollback happens, the revision number is incremented by 1. The first revision number is always 1

https://helm.sh/docs/intro/using_helm/#:~:text=Every%20time

@tuunit
Copy link
Member

tuunit commented Sep 1, 2023

I'll consider a feature flag to use helm-diff and only execute an upgrade if something truly changed but that shouldn't happen by default.

@tuunit tuunit changed the title The revision is still incrementing feat: only upgrade helm on change Sep 1, 2023
@tuunit tuunit added this to the 1.3.0 milestone Sep 1, 2023
@tuunit tuunit modified the milestones: 1.3.0, 1.4.0 Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants