Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use code annotations for style etc #47

Open
lsf37 opened this issue Feb 18, 2021 · 1 comment
Open

use code annotations for style etc #47

lsf37 opened this issue Feb 18, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lsf37
Copy link
Member

lsf37 commented Feb 18, 2021

Mostly putting this here so someone can pick it up if they feel like implementing it:

It could be nice to have the style checker directly comment on the code instead of outputting a diff (see also theory-linter, which does that)

Main blocker for that is that code annotations for GitHub actions only work for PRs from within the repo, not for forks, which is the common case. You can implement comments/code annotations from a GitHub app, though. This would have to be written and hosted somewhere. That is all solvable, but needs someone with a bit of time and web app knowledge.

@lsf37 lsf37 added enhancement New feature or request help wanted Extra attention is needed labels Feb 18, 2021
@lsf37
Copy link
Member Author

lsf37 commented Apr 10, 2021

Could potentially use the a separate workflow for the annotations, using a workflow_run tigger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant