Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make style check report only on lines changed in PR #46

Open
lsf37 opened this issue Feb 18, 2021 · 0 comments
Open

Make style check report only on lines changed in PR #46

lsf37 opened this issue Feb 18, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@lsf37
Copy link
Member

lsf37 commented Feb 18, 2021

On PR, it'd be cool to have the style checker to only demand style corrections for the lines that were changed, and warn (but not demand a fix) for the rest of the file.

We basically need an intersection of diff lines: take all diff lines from the style checker diff that also occur in the PR diff.
@lsf37 lsf37 added the enhancement New feature or request label Feb 18, 2021
@lsf37 lsf37 added the good first issue Good for newcomers label Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lsf37