Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-end test doesn't work with docker => Replace "-it" flag in docker run #7

Open
gruberma opened this issue Feb 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gruberma
Copy link
Contributor

I use the "-it" flags, when running flapy.sh run locally, so that the user can kill the process using Ctrl-C:
https://github.com/se2p/FlaPy/blob/master/run_line.sh#L86

However, this causes the end-to-end test to fail with the input device is not a TTY when using docker. For podman it works fine.

=> Remove the "-it" flag, but add some mechanism to make the process killable via Ctr-C

@gruberma gruberma added the bug Something isn't working label Feb 23, 2023
@FabianScharnboeck
Copy link
Contributor

FabianScharnboeck commented Mar 13, 2023

Probably you could just start the container without the "-it" option. Then you have to adjust the docker run command with "docker run --name 'my_custom_name'" to reference the container after you've started it. With "docker exec 'my_custom_name'" you should be able to hop into the container just like in interactive mode, right?

This removes the -it option which causes the TTY error, but nevertheless, you can use the container in interactive mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants