-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve construction of multi-relation networks #119
Comments
As a first step, we may want to check whether there is only one relation present in the network configuration, then only merge if there are more than one. This is basically a patch analogous to the function |
This is fixed in commit 0666f1f#diff-7a643d3b27ce60a62055308f46770341R1128-R1132. |
Signed-off-by: Claus Hunsen <[email protected]>
Signed-off-by: Claus Hunsen <[email protected]>
Description
The construction of multi-relation networks is quite complex in the sense of run-time overhead: We construct the separate networks (by constructing edge lists and, then, networks), transform these to edge lists again, merge them, and construct a merged network in the end. Instead, we should construct edge lists, merge those, and construct a network only once – and improve the run-time for complex and large networks!
Thus, we need to merge edge lists instead of networks here and here.
In the end, we may end up having the private network-construction methods (such as
get.author.network.cochange()
) returning a similar value as the functionconstruct.edge.list.from.key.value.list()
.Versions
This affects the upcoming version
v3.2
as it contains the code of PR #115.The text was updated successfully, but these errors were encountered: