Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata anonymize doesn't produce the right METADATA_SPEC_VERSION #2304

Open
npatki opened this issue Nov 20, 2024 · 0 comments
Open

Metadata anonymize doesn't produce the right METADATA_SPEC_VERSION #2304

npatki opened this issue Nov 20, 2024 · 0 comments
Labels
bug Something isn't working feature:metadata Related to describing the dataset

Comments

@npatki
Copy link
Contributor

npatki commented Nov 20, 2024

Environment Details

  • SDV version: 1.17.2

Background

Since SDV 1.17.0, we have consolidated the old SingleTableMetadata and MultiTableMetadata objects into a single, streamlined Metadata object. Along with this change, we have also updated the value that the "METADATA_SPEC_VERSION" parameter should have ("V1"). Eg.

{
    "tables": {
        "table": {
            "columns": {
                "age": { "sdtype": "numerical" },
                "gender": { "sdtype": "categorical" },
                ...
            }
        }
    },
    "METADATA_SPEC_VERSION": "V1"
}

Error Description

When I use the anonymize method on the metadata object, it returns a new metadata object that has not set the correct METADATA_SPEC_VERSION.

Eg. If I run metadata.anonymize() on the metadata above, I get the following:

{
    "tables": {
        "table": {
            "columns": {
                "col1": { "sdtype": "numerical" },
                "col2": { "sdtype": "categorical" },
                ...
            }
        }
    },
    "METADATA_SPEC_VERSION": "MULTI_TABLE_V1"
}

I expect it to be "V1" (not "MULTI_TABLE_V1")

@npatki npatki added bug Something isn't working feature:metadata Related to describing the dataset labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:metadata Related to describing the dataset
Projects
None yet
Development

No branches or pull requests

1 participant