Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling with HMA Synthesizer generates many SingleTableMetadata deprecation warnings #2290

Open
srinify opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working feature:sampling Related to generating synthetic data after a model is built

Comments

@srinify
Copy link
Contributor

srinify commented Nov 12, 2024

Environment Details

  • SDV version: 1.17.1 (latest)

Error Description

When sampling using an HMA Synthesizer object that was instantiated using a MultiTableMetadata object, the SingleTableMetadata deprecation warning is repeatedly logged:

Screenshot 2024-11-12 at 4 13 44 PM

This warning isn't very helpful (as it describes the SingleTableMetadata object) and repeats many times (it loosely seems like a larger volume of data generates more warnings). The user is already shown an accurate warning during synthesizer instantiation:

/usr/local/lib/python3.10/dist-packages/sdv/multi_table/base.py:110: FutureWarning: The 'MultiTableMetadata' is deprecated. Please use the new 'Metadata' class for synthesizers.
  warnings.warn(DEPRECATION_MSG, FutureWarning)

Steps to reproduce

Internal Colab Notebook to reproduce

from sdv.datasets.demo import download_demo
from sdv.metadata import MultiTableMetadata
from sdv.multi_table import HMASynthesizer

data, metadata = download_demo(
    modality='multi_table',
    dataset_name='fake_hotels'
)

guests_table = data['guests']
hotels_table = data['hotels']

multi_metadata = MultiTableMetadata()
multi_metadata.detect_from_dataframes(data)

synthesizer = HMASynthesizer(multi_metadata)
synthesizer.fit(real_data)
synthetic_data = synthesizer.sample()
@srinify srinify added bug Something isn't working feature:sampling Related to generating synthetic data after a model is built new Automatic label applied to new issues labels Nov 12, 2024
@npatki npatki removed the new Automatic label applied to new issues label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature:sampling Related to generating synthetic data after a model is built
Projects
None yet
Development

No branches or pull requests

2 participants