Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HyperTransformer Config class #457

Open
pvk-developer opened this issue Mar 25, 2022 · 0 comments
Open

HyperTransformer Config class #457

pvk-developer opened this issue Mar 25, 2022 · 0 comments
Labels
internal The issue doesn't change the API or functionality

Comments

@pvk-developer
Copy link
Member

Since a Config class has been introduced to rdt.HyperTransformer and following the suggestions on this comment: #456 (comment) we should consider moving some part of the logic thats currently held by the HyperTransformer to this Config class.

Expected behavior

The Config class should be responsible for updating and validating the field_transformers, _provided_field_transformers, field_sdtypes and _provided_field_sdtypes.

Additional context

The end user should be able to work with rdt.HyperTransformer as it is now, no new api changes are required.
The Config object shouldn't be necessary for the end user to create an instance or work with the HyperTransformer.
The Config object will be generated and stored in the hypertransformer as self.config or similar variable.
From the config we will perform the rest of the calls to get or use the transformers.

@pvk-developer pvk-developer added feature request Request for a new feature pending review labels Mar 25, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Apr 1, 2022
@amontanez24 amontanez24 removed this from the 1.0.0 milestone Apr 25, 2022
@npatki npatki added internal The issue doesn't change the API or functionality and removed feature request Request for a new feature pending review labels Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

No branches or pull requests

3 participants