-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HyperTransformer Config class #457
Labels
internal
The issue doesn't change the API or functionality
Comments
npatki
added
internal
The issue doesn't change the API or functionality
and removed
feature request
Request for a new feature
pending review
labels
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since a
Config
class has been introduced tordt.HyperTransformer
and following the suggestions on this comment: #456 (comment) we should consider moving some part of the logic thats currently held by theHyperTransformer
to thisConfig
class.Expected behavior
The
Config
class should be responsible for updating and validating thefield_transformers
,_provided_field_transformers
,field_sdtypes
and_provided_field_sdtypes
.Additional context
The end user should be able to work with
rdt.HyperTransformer
as it is now, no new api changes are required.The
Config
object shouldn't be necessary for the end user to create an instance or work with theHyperTransformer
.The
Config
object will be generated and stored in thehypertransformer
asself.config
or similar variable.From the
config
we will perform the rest of the calls to get or use the transformers.The text was updated successfully, but these errors were encountered: