Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating the get_likelihood method #303

Open
fealho opened this issue Nov 22, 2021 · 0 comments
Open

Investigating the get_likelihood method #303

fealho opened this issue Nov 22, 2021 · 0 comments
Labels
bug There is an error in the code that needs to be fixed

Comments

@fealho
Copy link
Member

fealho commented Nov 22, 2021

The get_likelihood method below may not work as expected:

def get_likelihood(self, uni_matrix):
"""Compute likelihood of the vine."""
# TODO: explain what this is supposed to do and make it work
# TODO: Alternatively, remove it.
num_tree = len(self.trees)
values = np.empty([1, num_tree])
for i in range(num_tree):
value, new_uni_matrix = self.trees[i].get_likelihood(uni_matrix)
uni_matrix = new_uni_matrix
values[0, i] = value
return np.sum(values)

An explanation of what this method does should be added, and we should investigate whether it works as expected.

@fealho fealho added the bug There is an error in the code that needs to be fixed label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is an error in the code that needs to be fixed
Projects
None yet
Development

No branches or pull requests

1 participant