From 55e80565f892c03328f9dbc15fa98af19b8b5414 Mon Sep 17 00:00:00 2001 From: Felipe Alex Hofmann Date: Tue, 23 Nov 2021 07:45:25 -0800 Subject: [PATCH] Add `flake8-fixme` (#294) * Add addon * Remove fixme * Add addon * Remove fixme * Fix bug --- copulas/multivariate/vine.py | 2 -- setup.py | 1 + tests/unit/multivariate/test_gaussian.py | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/copulas/multivariate/vine.py b/copulas/multivariate/vine.py index 27dff9dc..5c801af4 100644 --- a/copulas/multivariate/vine.py +++ b/copulas/multivariate/vine.py @@ -248,8 +248,6 @@ def train_vine(self, tree_type): def get_likelihood(self, uni_matrix): """Compute likelihood of the vine.""" - # TODO: explain what this is supposed to do and make it work - # TODO: Alternatively, remove it. num_tree = len(self.trees) values = np.empty([1, num_tree]) diff --git a/setup.py b/setup.py index 19a6d75a..a72fdd7f 100644 --- a/setup.py +++ b/setup.py @@ -40,6 +40,7 @@ 'flake8-debugger>=4.0.0,<4.1', 'flake8-mock>=0.3,<0.4', 'flake8-mutable>=1.2.0,<1.3', + 'flake8-fixme>=1.1.1,<1.2', 'pep8-naming>=0.12.1,<0.13', 'dlint>=0.11.0,<0.12', 'flake8-docstrings>=1.5.0,<2', diff --git a/tests/unit/multivariate/test_gaussian.py b/tests/unit/multivariate/test_gaussian.py index 6f9073d4..d24fcc03 100644 --- a/tests/unit/multivariate/test_gaussian.py +++ b/tests/unit/multivariate/test_gaussian.py @@ -458,7 +458,7 @@ def test_sample_constant_column(self): # Check assert result.shape == (5, 2) - results = result[~result.is()].all() + results = result[~result.isna()].all() assert results.all() assert result.loc[:, 0].equals(pd.Series([1.0, 1.0, 1.0, 1.0, 1.0], name=0))