Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (ctgan): add discriminator to model attributes #422

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix (ctgan): add discriminator to model attributes #422

wants to merge 1 commit into from

Conversation

MazenAli
Copy link

This adds the discriminator to model attributes. I found it strange to discard the trained discriminator after fitting as it can still be useful.

@MazenAli MazenAli requested a review from a team as a code owner November 21, 2024 13:24
@MazenAli MazenAli requested review from frances-h and removed request for a team November 21, 2024 13:24
@MazenAli MazenAli force-pushed the fix/ctgan/fit/discriminator_assign branch from fc0b3e3 to 4d2a234 Compare November 27, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frances-h frances-h Awaiting requested review from frances-h frances-h is a code owner automatically assigned from sdv-dev/core-contributors

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MazenAli