Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command name for dependency checker #345

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix command name for dependency checker #345

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21bafbc
Fixing typo in make check-deps
amontanez24 Mar 14, 2024
f24fdaf
trying to filter for specific library
amontanez24 Mar 14, 2024
3e07c12
fixing command
amontanez24 Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,6 @@ release-major: check-release bumpversion-major release
# Dependency targets

.PHONY: check-deps
checkdeps:
$(eval allow_list='numpy|pandas|scikit-learn|tqdm|torch|rdt')
check-deps:
$(eval allow_list='numpy=|pandas=|scikit-learn=|tqdm=|torch=|rdt=')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the equals because without it, other libraries with the same prefix were picked up (ie. pandas-vet)

pip freeze | grep -v "CTGAN.git" | grep -E $(allow_list) > $(OUTPUT_FILEPATH)
Loading