From abaece3d7ac91c7e05d3e5defad6487200d184b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20S=C3=A1nchez-Gallego?= <gallegoj@uw.edu>
Date: Tue, 23 Jul 2024 08:14:27 -0700
Subject: [PATCH 1/3] Set umask in entrypoint

---
 docker/Dockerfile           | 7 ++++++-
 docker/docker-entrypoint.sh | 5 +++++
 2 files changed, 11 insertions(+), 1 deletion(-)
 create mode 100644 docker/docker-entrypoint.sh

diff --git a/docker/Dockerfile b/docker/Dockerfile
index f1009d0..0856b05 100644
--- a/docker/Dockerfile
+++ b/docker/Dockerfile
@@ -33,6 +33,11 @@ RUN cd lvmguider && pip3 install .
 RUN rm -Rf lvmguider
 
 # Set umask so that new files inherit the parent folder permissions.
+# Not sure this works so we are also setting the permissions in the entrypoint.
 RUN echo "umask 0002" >> /etc/bash.bashrc
 
-ENTRYPOINT pip3 install -U astropy-iers-data; lvmguider actor start --debug
+COPY ./docker/docker-entrypoint.sh /
+RUN ["chmod", "+x", "/docker-entrypoint.sh"]
+
+ENTRYPOINT ["/docker-entrypoint.sh"]
+CMD ["sh", "-c", "lvmguider actor start --debug"]
diff --git a/docker/docker-entrypoint.sh b/docker/docker-entrypoint.sh
new file mode 100644
index 0000000..d398279
--- /dev/null
+++ b/docker/docker-entrypoint.sh
@@ -0,0 +1,5 @@
+#!/bin/bash
+umask 0002
+
+pip3 install -U astropy-iers-data
+exec "$@"

From 6ff43257eb6b56cef6986db6b27831c170b50e60 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20S=C3=A1nchez-Gallego?= <gallegoj@uw.edu>
Date: Tue, 23 Jul 2024 08:27:50 -0700
Subject: [PATCH 2/3] Update changelog

---
 CHANGELOG.md | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7408453..ce465ff 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## Next version
+
+* [#24](https://github.com/sdss/lvmguider/pull/24) Ensure group write permissions for new files in Docker container.
+
+
 ## 0.5.3 - June 1, 2024
 
 ### 🔧 Fixed

From e024c26de700a86e0d027d4cef01472c2baff11d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20S=C3=A1nchez-Gallego?= <gallegoj@uw.edu>
Date: Tue, 23 Jul 2024 08:51:17 -0700
Subject: [PATCH 3/3] Add subsection to CHANGELOG

---
 CHANGELOG.md | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce465ff..1ec2272 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Next version
 
+### ✨ Improved
+
 * [#24](https://github.com/sdss/lvmguider/pull/24) Ensure group write permissions for new files in Docker container.