Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors #3

Open
scondas opened this issue Nov 30, 2019 · 8 comments · May be fixed by #7
Open

Add sensors #3

scondas opened this issue Nov 30, 2019 · 8 comments · May be fixed by #7

Comments

@scondas
Copy link

scondas commented Nov 30, 2019

  • waterfurnace version: 1.1.0
  • Python version: 3.7
  • Operating System: Windows 10

Description

I was trying to retrieve the Leaving Water Temperature (LWT) and the loop flow rate data that
is available on some Water Furnace units. The current waterfurnace code does not support
these sensors.

What I Did

Looked at the code and did not see the LeavingWaterTemp and WaterFlowRate sensors
being queried.  
@mdallaire
Copy link
Contributor

Can you check this thread home-assistant/core#18306 (comment) and run a chrome debug to find out/confirm the value name returned for your system?

@scondas
Copy link
Author

scondas commented Nov 30, 2019

The sensors I am looking for do not appear in the awlclientproxy messages you referenced. I have hacked your code and guessed the sensor names as LeavingWaterTemp and WaterFlowRate, and they are reporting reasonable values against a Series 7 system. I am now working on a patch following the instructions in your repo. I do not, however, have a series 5 to test against to make sure it works correctly against those units.

@scondas
Copy link
Author

scondas commented Nov 30, 2019

mdallaire, I am getting the following error on the flake8 test BEFORE I added my changes:

tests/test_waterfurnace.py:10:1: F401 'waterfurnace.waterfurnace' imported but unused

Is this correct?

@scondas
Copy link
Author

scondas commented Dec 2, 2019

I found a bug I introduced into cli.py. I have deleted that branch. Sorry

@scondas
Copy link
Author

scondas commented Jun 23, 2020

Can you check this thread home-assistant/core#18306 (comment) and run a chrome debug to find out/confirm the value name returned for your system?

mdallaire Are you considering accepting my proposed changes, or should I instead fork the code? Thanks.

@mdallaire
Copy link
Contributor

I am not the owner of the repo, I just tried to help you figure out the correct websocket values. @sdague is the owner of the repo and would need to merge the change.
However I suspect that you will need to rework it since it looks like you request to merge your whole python venv.

@scondas
Copy link
Author

scondas commented Jun 23, 2020

Thanks!

I am not the owner of the repo, I just tried to help you figure out the correct websocket values. @sdague is the owner of the repo and would need to merge the change.
However I suspect that you will need to rework it since it looks like you request to merge your whole python venv.

Thanks!

@scondas scondas linked a pull request Aug 7, 2020 that will close this issue
@dougfultz
Copy link

@sdague Any chance we can get #7 merged in and get https://pypi.org/project/waterfurnace updated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants