Aborting socket::connect() doesn't work with iouring backend #2302
Comments
xemul
added a commit
to xemul/seastar
that referenced
this issue
Jun 26, 2024
There are two places that can wait for undefined amount of time -- the one that waits the connection pool to release a connection and the one that establishes a new connection. The former is simple, as it uses conditional variable, so just wait() on it with the timeout and return back timeout error if it fired. Tha latter is trickier. New connections come from factory and it's not guaranteed that a factory obeys it (e.g. see scylladb#2302). So instead of relying on the factory, check if connected_socket appeared soon enough and return back timeout error if it didn't. Signed-off-by: Pavel Emelyanov <[email protected]>
xemul
added a commit
to xemul/seastar
that referenced
this issue
Jun 26, 2024
There are two places that can wait for undefined amount of time -- the one that waits the connection pool to release a connection and the one that establishes a new connection. The former is simple, as it uses conditional variable, so just wait() on it with the timeout and return back timeout error if it fired. Tha latter is trickier. New connections come from factory and it's not guaranteed that a factory obeys it (e.g. see scylladb#2302). So instead of relying on the factory, check if connected_socket appeared soon enough and return back timeout error if it didn't. Signed-off-by: Pavel Emelyanov <[email protected]>
This was referenced Jun 27, 2024
tchaikov
added a commit
to tchaikov/seastar
that referenced
this issue
Jul 1, 2024
to workaround scylladb#2302, before it is fixed. Refs scylladb#2302 Signed-off-by: Kefu Chai <[email protected]>
this reminds me the discussion at #1633 (comment) |
xemul
pushed a commit
that referenced
this issue
Jul 1, 2024
to workaround #2302, before it is fixed. Refs #2302 Signed-off-by: Kefu Chai <[email protected]> Closes #2317
ptrsmrn
pushed a commit
to ptrsmrn/seastar
that referenced
this issue
Jul 17, 2024
to workaround scylladb#2302, before it is fixed. Refs scylladb#2302 Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2317
lovio
pushed a commit
to lovio/seastar
that referenced
this issue
Aug 30, 2024
to workaround scylladb#2302, before it is fixed. Refs scylladb#2302 Signed-off-by: Kefu Chai <[email protected]> Closes scylladb#2317
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's a new test #2301 that passes on linux-aio and fails on io-uring
The text was updated successfully, but these errors were encountered: