Actually working min-deps job #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
commented
Nov 4, 2024
| "h5py>=3.6", | ||
| "h5py>=3.7", |
There was a problem hiding this comment.
h5py 3.6.0 doesn’t build on macOS M1, 3.7.0 has wheels.
Idk if that’s a good reason to bump the min deps …
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3337 +/- ##
=======================================
Coverage 76.59% 76.59%
=======================================
Files 111 111
Lines 12827 12827
=======================================
Hits 9825 9825
Misses 3002 3002 |
ilan-gold
reviewed
Nov 8, 2024
grst
reviewed
Nov 11, 2024
meeseeksmachine
pushed a commit
to meeseeksmachine/scanpy
that referenced
this pull request
Nov 14, 2024
flying-sheep
added a commit
that referenced
this pull request
Nov 14, 2024
…3366) Co-authored-by: Philipp A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hia everyone, this should actually make
hatch test -i deps=minwork even on Macbooks.Maybe there’s a way to put the constraint file inside of the venv, then it’ll survive reboots on Linux.
I tagged you all because I thought you might be interested in this.