Keep .X when setting filename to None #1724
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1724 +/- ##
==========================================
- Coverage 87.01% 84.51% -2.50%
==========================================
Files 40 40
Lines 6059 6059
==========================================
- Hits 5272 5121 -151
- Misses 787 938 +151
|
|
@eroell Please add a test to check the behavior is correct of this so we can verify the fix actually works |
|
Added a minimal check to verify this behaviour |
|
added, @ilan-gold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does _to_memory_mode only get called by the filename setter anyways? And are there reasons to not just call to_memory from this setter?
If not worth to go in depths here anymore, the removed
_would fix a bug for now I guess