Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: embed zktrie spec in rust docs using github links for images #71

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

frisitano
Copy link
Collaborator

Previously we were using paths to images when defining the markdown for the zktrie spec. This was breaking the render when generating rust docs so instead we migrated to using links to the images hosted on github and also included the spec directly in the trie library docs instead of the README.md.

@frisitano frisitano requested a review from greged93 December 9, 2024 10:22
greged93
greged93 previously approved these changes Dec 9, 2024
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano requested a review from greged93 December 9, 2024 13:26
@frisitano frisitano merged commit 82aa95a into scroll Dec 9, 2024
39 checks passed
@frisitano frisitano deleted the fix/embed-zktrie-spec-in-docs branch December 9, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants