Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation cleanup: merge slt & sltu opcode circuit #650

Open
hero78119 opened this issue Nov 28, 2024 · 0 comments
Open

implementation cleanup: merge slt & sltu opcode circuit #650

hero78119 opened this issue Nov 28, 2024 · 0 comments
Assignees
Labels
cleanup Refactors, simplifications, hindsight 20/20 tasks.

Comments

@hero78119
Copy link
Collaborator

The config can be merged similar as in mulh.rs

enum MulhSignDependencies<E: ExtensionField> {
UU {
constrain_rd: IsEqualConfig,
},
SU {
rs1_signed: Signed<E>,
rd_signed: Signed<E>,
constrain_rd: IsEqualConfig,
},
SS {
rs1_signed: Signed<E>,
rs2_signed: Signed<E>,
rd_signed: Signed<E>,
},
}

@hero78119 hero78119 added the cleanup Refactors, simplifications, hindsight 20/20 tasks. label Nov 28, 2024
@hero78119 hero78119 changed the title implementation cleanup: merge slt & sltu opcode circuit implementation implementation cleanup: merge slt & sltu opcode circuit Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Refactors, simplifications, hindsight 20/20 tasks.
Projects
None yet
Development

No branches or pull requests

2 participants